fix(gotrue): allow refreshSession with refreshToken when no current session exists#1263
Merged
grdsdev merged 1 commit intoNov 10, 2025
Conversation
…ession exists Remove redundant check that required currentSession.accessToken to exist. The method now correctly works when a refreshToken is provided as a parameter, even if there's no current session. The existing null check for the refresh token is sufficient to handle both cases. Fixes #1261
mandarini
approved these changes
Nov 10, 2025
grdsdev
deleted the
guilherme/sdk-514-refreshsession-shouldnt-fail-because-currentsession-doesnt
branch
Pull Request Test Coverage Report for Build 19234218247Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1261
This PR removes the redundant check that required
currentSession.accessTokento exist before allowing a session refresh.Problem
The
refreshSessionmethod was throwing anAuthSessionMissingExceptionwhen there was no current session, even if a validrefreshTokenwas provided as a parameter. This blocked a valid use case where you might have a refresh token but no current session.Solution
currentSession?.accessToken == nullcurrentSessionRefreshToken == null) is sufficient to handle both cases:refreshTokenparameter is provided_currentSession?.refreshTokenChanges
packages/gotrue/lib/src/gotrue_client.dart: Removed redundant check, updated docspackages/gotrue/test/client_test.dart: Added test for refreshSession with refreshToken when no current session existsTesting
refreshSession(refreshToken)works whencurrentSessionis null